Remove build-std cargo option and switch to core::intrinsics::abort() in panic_handler#135
Closed
Remove build-std cargo option and switch to core::intrinsics::abort() in panic_handler#135
build-std cargo option and switch to core::intrinsics::abort() in panic_handler#135Conversation
components and Miden SDK tests. The panic handler and global allocator is now set in the `lib.rs` file of each component crate. Before, the `cargo-component-bindings` was not built correctly for `no_std` and was linking the stdlib allocator. The Rust bindings for the WIT are now generated in the `src` directory of the component crate, instead of the `target/.../bindings` directory. The Wasm `bulk-memory` proposal is enabled via `RUSTFLAGS` so that `memcpy` function import is replaced with Wasm `memory.copy` op.
Add Wasm component translation support to `CompileTest`. Draft a text representation of the IR `Component` and use it in the expected tests.
Swap function calls to imported functions with the external function passed as module arguments.
according to the instantiation order
in the final stage of the translation to make the overall algorithm and steps more clear and concise. Raise errors when an particular item translation is not(yet) implemented.
temporary use u64 for Felt in WIT.
since at component boundaries every function is invoked via `call`.
in panic_handler.
greenhat
changed the title
build-std cargo option and switch to core::intrinsics::abort() in panic_handlerbuild-std cargo option and switch to core::intrinsics::abort() in panic_handler
Contributor
Author
|
@bitwalker I switched to using |
greenhat
changed the title
build-std cargo option and switch to core::intrinsics::abort() in panic_handlerbuild-std cargo option and switch to core::intrinsics::abort() in panic_handler
greenhat
force-pushed
the
greenhat/remove-invoke-method
branch
from
a77c8c8 to
eab6463
Compare
bitwalker
force-pushed
the
greenhat/remove-invoke-method
branch
from
eab6463 to
4dfcbfe
Compare
Collaborator
|
Closing this as stale, and not needed (there is a stabilized abort intrinsic now anyway that we can use, i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #134 and should be merged after it
Close #124